cmake: Parse ZEPHYR_TOOLCHAIN_VARIANT in SDK instead of Zephyr #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
force-pushed
the
sdk-parse-variant
branch
3 times, most recently
from
df2145e to
f016697
Compare
When ZEPHYR_TOOLCHAIN_VARIANT is of the form toolchain/compiler, it needs to be split into the toolchain (which overwrites ZEPHYR_TOOLCHAIN_VARIANT) and compiler (stored in TOOLCHAIN_VARIANT_COMPILER). Otherwise, when defined, it is left alone. When undefined it is set to "zephyr". Finally, if the value is "zephyr" and no TOOLCHAIN_VARIANT_COMPILER setting is present, then TOOLCHAIN_VARIANT_COMPILER is set to "gnu". This allows existing configurations which set ZEPHYR_TOOLCHAIN_VARIANT to "zephyr" to work with the new SDK and allows Zephyr to easily support both old and new variable settings during the SDK transition period. Finally, write both values into the environment so that Kconfig can use them. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
sdk-parse-variant
branch
from
fb07875 to
55a01a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ZEPHYR_TOOLCHAIN_VARIANT is of the form toolchain/compiler, it needs to be split into the toolchain (which overwrites ZEPHYR_TOOLCHAIN_VARIANT) and compiler (stored in
TOOLCHAIN_VARIANT_COMPILER).
Otherwise, when defined, it is left alone. When undefined it is set to "zephyr".
Finally, if the value is "zephyr" and no TOOLCHAIN_VARIANT_COMPILER setting is present, then TOOLCHAIN_VARIANT_COMPILER is set to "gnu".
This allows existing configurations which set ZEPHYR_TOOLCHAIN_VARIANT to "zephyr" to work with the new SDK and allows Zephyr to easily support both old and new variable settings during the SDK transition period.